Idefisk
Tools
Tutorials
Reviews
VoIP Providers
Archives
AsteriskGuru Archives
Mailing List Archives
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
[Asterisk-Dev] Another SIP fix
AsteriskGuru Archives Forum Index
->
Asterisk-Dev
View previous topic
::
View next topic
Author
Message
asterisk-dev at lists.dig
Guest
Posted: Mon Mar 31, 2003 1:43 pm
Post subject: [Asterisk-Dev] Another SIP fix
--19701020
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Fixes a couple of crashers in chan_sip.
-- Luke
--19701020
Content-Type: text/plain; name="chan_sip.diff"; x-unix-mode=0644
Content-Disposition: attachment; filename="chan_sip.diff"
Index: channels/chan_sip.c
===================================================================
RCS file: /usr/cvsroot/asterisk/channels/chan_sip.c,v
retrieving revision 1.23
diff -u -r1.23 chan_sip.c
--- channels/chan_sip.c 31 Mar 2003 03:19:34 -0000 1.23
+++ channels/chan_sip.c 31 Mar 2003 13:49:50 -0000
@@ -363,13 +363,16 @@
} else {
/* If no owner, destroy now */
sip_destroy(pkt->owner);
+ pkt = NULL;
}
}
} else {
/* Don't bother retransmitting. It's about to be killed anyway */
pkt->retransid = -1;
}
- ast_pthread_mutex_unlock(&pkt->owner->lock);
+ if (pkt != NULL) {
+ ast_pthread_mutex_unlock(&pkt->owner->lock);
+ }
return res;
}
@@ -2175,8 +2178,9 @@
char via[80];
char addr[80];
struct sip_pvt *p;
+
/* exit if we are already in process with this registrar ?*/
- if ( (auth==NULL && r->regstate==REG_STATE_REGSENT) || r->regstate==REG_STATE_AUTHSENT) {
+ if (r == NULL || (auth==NULL && r->regstate==REG_STATE_REGSENT) || r->regstate==REG_STATE_AUTHSENT) {
ast_log(LOG_NOTICE, "Strange, trying to register when registration already pending\n");
return 0;
}
--19701020
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
P.S. Mark, you might want to take a look at:
==29395==
==29395== Thread 14:
==29395== Conditional jump or move depends on uninitialised value(s)
==29395== at 0x401662D3: strcmp (vg_clientfuncs.c:477)
==29395== by 0x8064D86: pbx_builtin_getvar_helper (pbx.c:3900)
==29395== by 0x43CD7420: ??? (app_macro.c:124)
==29395== by 0x805E05F: pbx_exec (pbx.c:352)
--
Luke Howard | PADL Software Pty Ltd |
www.padl.com
--19701020--
Back to top
asterisk-dev at lists.dig
Guest
Posted: Mon Mar 31, 2003 2:23 pm
Post subject: [Asterisk-Dev] Another SIP fix
Actually, that appears to make things worse; let me take another
look (although it does fix the segfault my snom phone keeps
rebooting itself!).
-- Luke
Quote:
From: Luke Howard <lukeh@PADL.COM>
Subject: [Asterisk-Dev] Another SIP fix
To:
asterisk-dev@lists.digium.com
Date: Mon, 31 Mar 2003 23:43:19 +1000
Organization: PADL Software Pty Ltd
Versions: dmail (bsd44) 2.4c/makemail 2.9d
Fixes a couple of crashers in chan_sip.
-- Luke
[Attachment: chan_sip.diff, text/plain]
P.S. Mark, you might want to take a look at:
==29395==
==29395== Thread 14:
==29395== Conditional jump or move depends on uninitialised value(s)
==29395== at 0x401662D3: strcmp (vg_clientfuncs.c:477)
==29395== by 0x8064D86: pbx_builtin_getvar_helper (pbx.c:3900)
==29395== by 0x43CD7420: ??? (app_macro.c:124)
==29395== by 0x805E05F: pbx_exec (pbx.c:352)
--
Luke Howard | PADL Software Pty Ltd |
www.padl.com
--
Luke Howard | PADL Software Pty Ltd |
www.padl.com
Back to top
Display posts from previous:
All Posts
1 Day
7 Days
2 Weeks
1 Month
3 Months
6 Months
1 Year
Oldest First
Newest First
AsteriskGuru Archives Forum Index
->
Asterisk-Dev
All times are GMT
Page
1
of
1
Jump to:
Select a forum
Asterisk Mailing Lists
----------------
Asterisk-Users
Asterisk-Dev
Asterisk-CVS
Asterisk-Biz
Asterisk-Doc
Asterisk-BSD
Asterisk-Announce
Asterisk Call Centers
Asterisk-Video
Asterisk-Speech-Rec
Bristuff-Users
You
cannot
post new topics in this forum
You
cannot
reply to topics in this forum
You
cannot
edit your posts in this forum
You
cannot
delete your posts in this forum
You
cannot
vote in polls in this forum
Powered by
phpBB
© 2001, 2005 phpBB Group