• News
  • Idefisk
  • Tools
  • Tutorials
  • Forum
  • Reviews
  • VoIP Providers
  • Archives
  • Gallery
ZOIPER softphone
AsteriskGuru Archives
Mailing List Archives
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

[asterisk-dev] [Code Review] Diameter implementation of Aste

 
   AsteriskGuru Archives Forum Index -> Asterisk-Dev
View previous topic :: View next topic  
Author Message
russell at digium.com
Guest





PostPosted: Fri May 29, 2009 3:18 pm    Post subject: [asterisk-dev] [Code Review] Diameter implementation of Aste

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/268/
-----------------------------------------------------------

(Updated 2009-05-29 11:04:51.733584)


Review request for Asterisk Developers.


Changes
-------

Added mantis issue number


Summary
-------

The feature implements Base Accounting of Diameter protocol, the next generation AAA protocol which overcomes the drawbacks of RADIUS.

The architecture and design of the feature (diameter module) can be extended for applications like prepaid and credit control with ease.

The feature provides interface to integrate it with CDR module of asterisk.

Accounting in Diameter is handled in two different ways, Real-time accounting and One-time(Event based) accounting. The module takes care of both the types.

With the existing CDR feature of asterisk, one-time accounting is enabled and tested. The feature uses TCP for peer support. Peer state machine and Accounting Session state machine are implemented with reference to RFC 3588.
Every time CDR of a call is posted in asterisk, this feature sends an accounting message with CDR information to the Diameter Server. This feature also takes care of packet loss, retransmission and failover as per RFC 3588.

Interim accounting is also implemented in the feature but not tested. It is not yet integrated and enabled with Asterisk as I could not find a proper Diameter server to test Interim accounting. Storing and sending of accounting records in case of failures is not done as of now.


This addresses bug 15006.
https://issues.asterisk.org/view.php?id=15006


Diffs
-----

/trunk/cdr/Makefile 197957
/trunk/cdr/cdr_diameter.c PRE-CREATION
/trunk/cdr/diameter/diameter_avp.h PRE-CREATION
/trunk/cdr/diameter/diameter_avp.c PRE-CREATION
/trunk/cdr/diameter/diameter_base.h PRE-CREATION
/trunk/cdr/diameter/diameter_base.c PRE-CREATION
/trunk/cdr/diameter/diameter_message.h PRE-CREATION
/trunk/cdr/diameter/diameter_message.c PRE-CREATION
/trunk/cdr/diameter/diameter_module.tar.gz UNKNOWN
/trunk/cdr/diameter/diameter_session.h PRE-CREATION
/trunk/cdr/diameter/diameter_session.c PRE-CREATION
/trunk/cdr/diameter/diameter_transaction.h PRE-CREATION
/trunk/cdr/diameter/diameter_transaction.c PRE-CREATION
/trunk/cdr/diameter/diameter_transport.h PRE-CREATION
/trunk/cdr/diameter/diameter_transport.c PRE-CREATION
/trunk/cdr/diameter/tags PRE-CREATION

Diff: http://reviewboard.digium.com/r/268/diff


Testing
-------

The one-time accounting of this module is tested only with CDF Simulator of Open Cloud Diameter Resource Adaptors and Simulators.


Thanks,

leena_m


_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Back to top
sean.bright at gmail.com
Guest





PostPosted: Fri May 29, 2009 3:55 pm    Post subject: [asterisk-dev] [Code Review] Diameter implementation of Aste

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/268/#review806
-----------------------------------------------------------


Before I review this in depth, please:

a) Correct the formatting of the entire patch (there looks to be a mixture of tabs and spaces). See doc/CODING-GUIDELINES for details.
b) Remove all trailing whitespace (sed -r -e 's/\s+$//g' filename)
c) Remove the tags file from the diff.

- Sean


On 2009-05-29 11:04:51, leena_m wrote:
Quote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/268/
-----------------------------------------------------------

(Updated 2009-05-29 11:04:51)


Review request for Asterisk Developers.


Summary
-------

The feature implements Base Accounting of Diameter protocol, the next generation AAA protocol which overcomes the drawbacks of RADIUS.

The architecture and design of the feature (diameter module) can be extended for applications like prepaid and credit control with ease.

The feature provides interface to integrate it with CDR module of asterisk.

Accounting in Diameter is handled in two different ways, Real-time accounting and One-time(Event based) accounting. The module takes care of both the types.

With the existing CDR feature of asterisk, one-time accounting is enabled and tested. The feature uses TCP for peer support. Peer state machine and Accounting Session state machine are implemented with reference to RFC 3588.
Every time CDR of a call is posted in asterisk, this feature sends an accounting message with CDR information to the Diameter Server. This feature also takes care of packet loss, retransmission and failover as per RFC 3588.

Interim accounting is also implemented in the feature but not tested. It is not yet integrated and enabled with Asterisk as I could not find a proper Diameter server to test Interim accounting. Storing and sending of accounting records in case of failures is not done as of now.


This addresses bug 15006.
https://issues.asterisk.org/view.php?id=15006


Diffs
-----

/trunk/cdr/Makefile 197957
/trunk/cdr/cdr_diameter.c PRE-CREATION
/trunk/cdr/diameter/diameter_avp.h PRE-CREATION
/trunk/cdr/diameter/diameter_avp.c PRE-CREATION
/trunk/cdr/diameter/diameter_base.h PRE-CREATION
/trunk/cdr/diameter/diameter_base.c PRE-CREATION
/trunk/cdr/diameter/diameter_message.h PRE-CREATION
/trunk/cdr/diameter/diameter_message.c PRE-CREATION
/trunk/cdr/diameter/diameter_module.tar.gz UNKNOWN
/trunk/cdr/diameter/diameter_session.h PRE-CREATION
/trunk/cdr/diameter/diameter_session.c PRE-CREATION
/trunk/cdr/diameter/diameter_transaction.h PRE-CREATION
/trunk/cdr/diameter/diameter_transaction.c PRE-CREATION
/trunk/cdr/diameter/diameter_transport.h PRE-CREATION
/trunk/cdr/diameter/diameter_transport.c PRE-CREATION
/trunk/cdr/diameter/tags PRE-CREATION

Diff: http://reviewboard.digium.com/r/268/diff


Testing
-------

The one-time accounting of this module is tested only with CDF Simulator of Open Cloud Diameter Resource Adaptors and Simulators.


Thanks,

leena_m




_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
Back to top
Display posts from previous:   
   AsteriskGuru Archives Forum Index -> Asterisk-Dev All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
contact us at: support@asteriskguru.com - asterisKGuru.com © all rights reserved   |   *asterisk is registered trademark of © Digium™