I conjecture that one would expect any state that 'raises' the level of the combination above an idle state would return that state, and basically the 'less available' (busier so to speak) that the state is, it would take precedence. Most of the behavior appears that way with the exception that Idle is taking precedence of onHold which seems very counter-intuitive.
Before filing this as a "bug" I would like to get the feedback of others what would be the proper value of such a combination.
Posted: Fri May 08, 2009 12:28 am Post subject: [asterisk-dev] expected hint value when multiple devices are
On May 7, 2009, at 4:27 PM, Philippe Lindheimer wrote:
Quote:
OnHold & Idle = Idle (NOT WHAT ONE WOULD EXPECT)
I conjecture that one would expect any state that 'raises' the level
of the combination above an idle state would return that state, and
basically the 'less available' (busier so to speak) that the state
is, it would take precedence. Most of the behavior appears that way
with the exception that Idle is taking precedence of onHold which
seems very counter-intuitive.
Before filing this as a "bug" I would like to get the feedback of
others what would be the proper value of such a combination.
I would agree that this is a bug. I would expect that combination of
states to result in an OnHold state.
The fix should be relatively easy. The responsible code is in
ast_extension_state2() of main/pbx.c in Asterisk 1.4.
In Asterisk trunk, the same logic was moved into some common code.
Search for ast_devstate_aggregate in main/devicestate.c.
--
Russell Bryant
Digium, Inc. | Senior Software Engineer, Open Source Team Lead
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--
the 1.4 patch is tested and seems to work. The trunk patch should be ok but I don't have a system to build and test it against at the moment.
--- On Thu, 5/7/09, Russell Bryant <russell@digium.com> wrote:
Quote:
From: Russell Bryant <russell@digium.com>
Subject: Re: [asterisk-dev] expected hint value when multiple devices are combined (onHold)
To: p_lindheimer@yahoo.com, "Asterisk Developers Mailing List" <asterisk-dev@lists.digium.com>
Date: Thursday, May 7, 2009, 6:17 PM
Quote:
On May 7, 2009, at 4:27 PM, Philippe Lindheimer wrote:> OnHold & Idle = Idle (NOT WHAT ONE WOULD
EXPECT)> > I conjecture that one would expect any state that 'raises' thelevel of the combination above an idle state would return that state, andbasically the 'less available' (busier so to speak) that the state is,it would take precedence. Most of the behavior appears that way with theexception that Idle is taking precedence of onHold which seems verycounter-intuitive.> > Before filing this as a "bug" I would like to get the feedbackof others what would be the proper value of such a combination.I would agree that this is a bug. I would expect that combination of states toresult in an OnHold state.The fix should be relatively easy. The responsible code is inast_extension_state2() of main/pbx.c in Asterisk 1.4.In Asterisk trunk, the same logic was moved into some common code. Search forast_devstate_aggregate in main/devicestate.c.--Russell
BryantDigium, Inc. | Senior Software Engineer, Open Source Team Lead445 Jan Davis Drive NW - Huntsville, AL 35806 - USACheck us out at: www.digium.com & www.asterisk.org
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum