Posted: Tue May 12, 2009 7:13 pm Post subject: [asterisk-dev] [Code Review] Fix issue #15088 and #14974, al
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
This patch fixes an issue in the AMI that when logging out makes asterisk crash.
Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
Posted: Tue May 12, 2009 7:45 pm Post subject: [asterisk-dev] [Code Review] Fix issue #15088 and #14974, al
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/#review773
-----------------------------------------------------------
You added a mutex in here and several calls to ast_mutex_init. However, you did not add any calls to ast_mutex_destroy.
- Mark
On 2009-05-12 14:59:29, Eliel Sardañons wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/
-----------------------------------------------------------
(Updated 2009-05-12 14:59:29)
Review request for Asterisk Developers.
Summary
-------
This patch fixes an issue in the AMI that when logging out makes asterisk crash.
Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
Posted: Tue May 12, 2009 7:56 pm Post subject: [asterisk-dev] [Code Review] Fix issue #15088 and #14974, al
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/
-----------------------------------------------------------
(Updated 2009-05-12 15:46:38.827558)
Review request for Asterisk Developers.
Changes
-------
Added ast_mutex_destroy() when needed.
Thanks putnopvut
Summary
-------
This patch fixes an issue in the AMI that when logging out makes asterisk crash.
Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
Posted: Tue May 12, 2009 7:58 pm Post subject: [asterisk-dev] [Code Review] Fix issue #15088 and #14974, al
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/#review774
-----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/
-----------------------------------------------------------
(Updated 2009-05-12 15:46:38)
Review request for Asterisk Developers.
Summary
-------
This patch fixes an issue in the AMI that when logging out makes asterisk crash.
Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
Posted: Tue May 12, 2009 8:03 pm Post subject: [asterisk-dev] [Code Review] Fix issue #15088 and #14974, al
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/#review775
-----------------------------------------------------------
Ship it!
Looks good to me! Great work!
- Mark
On 2009-05-12 15:46:38, Eliel Sardañons wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/248/
-----------------------------------------------------------
(Updated 2009-05-12 15:46:38)
Review request for Asterisk Developers.
Summary
-------
This patch fixes an issue in the AMI that when logging out makes asterisk crash.
Also there where many warning messages related to astobj2, this warnings where caused while trying to lock a mansession (that is not an astob2), so the mansession was never being locked.
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum