Posted: Thu May 14, 2009 9:09 pm Post subject: [asterisk-dev] [Code Review] Const-ify the world (or at leas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
Posted: Mon May 18, 2009 6:05 pm Post subject: [asterisk-dev] [Code Review] Const-ify the world (or at leas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/#review785
-----------------------------------------------------------
If we're changing this anyway, is there a reason we don't make it "const char *" instead of "const void *" ?
- Russell
On 2009-05-14 17:00:19, Kevin Fleming wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/
-----------------------------------------------------------
(Updated 2009-05-14 17:00:19)
Review request for Asterisk Developers.
Summary
-------
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
Posted: Thu May 21, 2009 5:53 pm Post subject: [asterisk-dev] [Code Review] Const-ify the world (or at leas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/
-----------------------------------------------------------
(Updated 2009-05-21 13:42:55.268577)
Review request for Asterisk Developers.
Changes
-------
Updated to latest trunk, and addressed Russell's request to change the 'data' argument of dialplan application handlers to the proper type (const char *).
Summary
-------
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
Posted: Thu May 21, 2009 7:42 pm Post subject: [asterisk-dev] [Code Review] Const-ify the world (or at leas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/#review789
-----------------------------------------------------------
It looks like the changes in this file didn't get updated for "const char *"
- Russell
On 2009-05-21 13:42:55, Kevin Fleming wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/
-----------------------------------------------------------
(Updated 2009-05-21 13:42:55)
Review request for Asterisk Developers.
Summary
-------
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
Posted: Thu May 21, 2009 8:05 pm Post subject: [asterisk-dev] [Code Review] Const-ify the world (or at leas
Quote:
On 2009-05-21 15:34:16, Russell Bryant wrote:
> /trunk/apps/app_macro.c, lines 453-466
> <http://reviewboard.digium.com/r/251/diff/2/?file=5311#file5311line453>
>
> Hm, but it looks like tmp3 isn't actually declared as const. So, is the cast needed?
Correct; that's a left-over comment from when I had made more const changes (specifically to the return type of ast_str_buffer()). I'll remove the comment before committing.
Quote:
On 2009-05-21 15:34:16, Russell Bryant wrote:
> /trunk/apps/app_osplookup.c, line 1300
> <http://reviewboard.digium.com/r/251/diff/2/?file=5320#file5320line1300>
>
> It looks like the changes in this file didn't get updated for "const char *"
Yep; will fix during commit.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/#review789
-----------------------------------------------------------
On 2009-05-21 13:42:55, Kevin Fleming wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/251/
-----------------------------------------------------------
(Updated 2009-05-21 13:42:55)
Review request for Asterisk Developers.
Summary
-------
This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum