Posted: Fri May 29, 2009 3:27 pm Post subject: [asterisk-dev] [Code Review] New signaling module to handle
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/253/#review805
-----------------------------------------------------------
Ship it!
I pointed out a few formatting things in new/modified code. Check for and fix other places with trailing whitespace or switch/case not aligned properly.
Also, we discussed IRL yesterday about adding some comments to places where commented out code is left in. Please leave a note that explains why it is being left there so that someone else doesn't come behind you and remove it.
This code could certainly use some documentation love, but in this case, I'm okay with it going in without it for now.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/253/
-----------------------------------------------------------
(Updated 2009-05-26 12:58:44)
Review request for Asterisk Developers.
Summary
-------
This branch splits all the analog signaling logic out of chan_dahdi.c into sig_analog.c. Functionality in theory should not change at all.
The main testing I did was simply making calls. Once I got that working most everything else seemed to work. Specifically made sure caller id works for both sending and receiving as well.
Thanks,
Jeff
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
