Asterisk Guru

AsteriskGuru Archives
Mailing List Archives

FAQ

Memberlist

Usergroups

Profile

[asterisk-dev] [Code Review] Simplify the Makefile to avoid

AsteriskGuru Archives Forum Index -> Asterisk-Dev

View previous topic :: View next topic

Author

Message

sean.bright at gmail.com
Guest

Posted: Fri May 29, 2009 6:27 pm Post subject: [asterisk-dev] [Code Review] Simplify the Makefile to avoid

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/269/#review807
-----------------------------------------------------------

Ship it!

Looks good to me other than a very very minor point. Nice work!

/trunk/main/Makefile
<http://reviewboard.digium.com/r/269/#comment1993>

A little nitpicky, but I'd call this OBJSFILTER or FILTEROBJ

- Sean

On 2009-05-29 13:55:22, Eliel Sardañons wrote:

Quote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/269/
-----------------------------------------------------------

(Updated 2009-05-29 13:55:22)

Review request for Asterisk Developers.

Summary
-------

The idea is to remove all the list of objects files to be compiled & linked and make "make" :) generate the list for us.

Diffs
-----

/trunk/main/Makefile 197957

Diff: http://reviewboard.digium.com/r/269/diff

Testing
-------

asterisk compiles.

Thanks,

Eliel

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev

Display posts from previous:

AsteriskGuru Archives Forum Index -> Asterisk-Dev	All times are GMT
Page 1 of 1

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum